Mercurial > hg > Blog

annotate content/Eclipse/hooray-im-eclipse-contributor.md @ 89:101db19aa210

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
add a comment
author Dirk Olmes <dirk@xanthippe.ping.de>
date Wed, 06 Dec 2017 17:05:27 +0100
parents 030b4c55e6e2
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
31
030b4c55e6e2 add a post about my Eclipse contribution
Dirk Olmes <dirk@xanthippe.ping.de>
parents:
diff changeset
1 Title: Hooray I'm Eclipse contributor
030b4c55e6e2 add a post about my Eclipse contribution
Dirk Olmes <dirk@xanthippe.ping.de>
parents:
diff changeset
2 Date: 2014-08-06
030b4c55e6e2 add a post about my Eclipse contribution
Dirk Olmes <dirk@xanthippe.ping.de>
parents:
diff changeset
3 Lang: en
030b4c55e6e2 add a post about my Eclipse contribution
Dirk Olmes <dirk@xanthippe.ping.de>
parents:
diff changeset
4
030b4c55e6e2 add a post about my Eclipse contribution
Dirk Olmes <dirk@xanthippe.ping.de>
parents:
diff changeset
5 While doing a big refactoring for a customer I stumbled over a missing feature in Eclipse's refactoring dialog: you cannot double-click to expand packages in the dialog that selects the destination when moving classes.
030b4c55e6e2 add a post about my Eclipse contribution
Dirk Olmes <dirk@xanthippe.ping.de>
parents:
diff changeset
6
030b4c55e6e2 add a post about my Eclipse contribution
Dirk Olmes <dirk@xanthippe.ping.de>
parents:
diff changeset
7 This was a good chance to actually do some hacking in JDT. I was able to add the feature fairly quickly but then I had trouble contributing the fix back to Eclipse. First, I tried [on github](https://github.com/eclipse/eclipse.jdt.ui/pull/5) as the Eclipse source was hosted there. But the pull request kept sitting by itself fairly unnoticed for quite some time.
030b4c55e6e2 add a post about my Eclipse contribution
Dirk Olmes <dirk@xanthippe.ping.de>
parents:
diff changeset
8
030b4c55e6e2 add a post about my Eclipse contribution
Dirk Olmes <dirk@xanthippe.ping.de>
parents:
diff changeset
9 Then my dear friend [Holger](https://twitter.com/@asynchronaut) brought my attention to a [blog post by Lars Vogel](http://blog.vogella.com/2014/03/27/eclipse-platform-contributors-please-convert-any-patch-you-have-to-a-gerrit-review/) which suggests using Eclipse's Gerrit review platform for contributions.
030b4c55e6e2 add a post about my Eclipse contribution
Dirk Olmes <dirk@xanthippe.ping.de>
parents:
diff changeset
10
030b4c55e6e2 add a post about my Eclipse contribution
Dirk Olmes <dirk@xanthippe.ping.de>
parents:
diff changeset
11 So I repackaged my fix as a [Gerrit commit](https://git.eclipse.org/r/#/c/24217/). Much to my surprise the contribution got attention by someone at Eclipse. After some time it even made its way back into the main platform. So it seems like I'm an Eclipse contributor now :-)